expose OutputFormatEnum instead of ResultFormat to user #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 82.89% 84.69% +1.80%
==========================================
Files 26 26
Lines 1397 1555 +158
==========================================
+ Hits 1158 1317 +159
+ Misses 239 238 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gordonwatts
approved these changes
Sep 30, 2024
Collaborator
gordonwatts
left a comment
gordonwatts
left a comment
There was a problem hiding this comment.
nice.will this break Api?
Collaborator
Author
Yes. However it would only ever have worked for someone who used parquet (since by definition root was broken) and I don't think it's actually documented anywhere in our user guide (!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #447 by changing the enum that is given to the user to be the one used by Pydantic to validate user input, instead of the one that defines interactions with the backend